findepi commented on code in PR #13817:
URL: https://github.com/apache/datafusion/pull/13817#discussion_r1891370208
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -93,60 +96,89 @@ pub enum Volatility {
pub enum TypeSignature {
/// One or more arguments of a common type out of a list of valid types.
///
+ /// For functions that take no arguments (e.g. `random()` see
[`TypeSignature::Nullary`]).
+ ///
/// # Examples
- /// A function such as `concat` is `Variadic(vec![DataType::Utf8,
DataType::LargeUtf8])`
+ ///
+ /// A function such as `concat` is `Variadic(vec![DataType::Utf8,
+ /// DataType::LargeUtf8])`
Review Comment:
nit:
Maybe it would be more readable to go without `DataType:` for type names?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
