Dandandan commented on code in PR #13832:
URL: https://github.com/apache/datafusion/pull/13832#discussion_r1891854834
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1613,10 +1611,10 @@ impl SortMergeJoinStream {
self.output_record_batches
.filter_mask
- .extend(&BooleanArray::from(vec![None; num_rows]));
+ .append_nulls(num_rows);
self.output_record_batches
.row_indices
- .extend(&UInt64Array::from(vec![None; num_rows]));
+ .append_nulls(num_rows);
self.output_record_batches
.batch_ids
.extend(vec![0; num_rows]);
Review Comment:
Btw this could avoid some allocation as well (using `resize` rather than
extend based on `Vec`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
