alamb commented on issue #13845: URL: https://github.com/apache/datafusion/issues/13845#issuecomment-2555749520
> I agree with @findepi, once it is merged it is a deferred problem and much harder to find the root cause. Yes, I also 100% agree. > My initial naive thought was to have smoke tests/correctness tests on PRs and more advanced things like benchmarks before the release, but this approach has the same flaw of deferred problem detection. Maybe we could still run the more advanced tests before *merging* a PR but would not run them all during development, review and iteration. This would ensure that if a PR introduced a problem it wouldn't be merged to main so the error is not deferred I expect in most cases the "extended" tests will simply pass and things will be fine. Occasionally the extended tests would fail and we would have to go dig into why before the PR was merged It seems like wishful thinking though, as I am not sure there is capacity to create and maintain such a workflow 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
