alamb commented on code in PR #13874:
URL: https://github.com/apache/datafusion/pull/13874#discussion_r1896169061
##########
datafusion/core/src/dataframe/parquet.rs:
##########
@@ -74,8 +74,16 @@ impl DataFrame {
let file_type = format_as_file_type(format);
+ let plan = if options.sort_by.is_empty() {
+ self.plan
+ } else {
+ LogicalPlanBuilder::from(self.plan)
+ .sort(options.sort_by)?
+ .build()?
+ };
+
Review Comment:
I think the ordering information is normally handled by a higher level
"catalog" rather than the parquet format itself.
This is the only thing I know of in Parquet, but I don't think it can
describe the ordering
https://github.com/apache/parquet-format/blob/d784f11f4485e64fdeaa614e0bde125f5132093d/src/main/thrift/parquet.thrift#L587-L591
Maybe this is something that https://iceberg.apache.org/ could represent 🤔
It is also conceivable that DataFusion itself could write custom metadata in
paquet and other formats that support that custom metadata with the ordering,
but that seems like we would just be reinventing Iceberg and similar table
formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
