alamb opened a new issue, #13898:
URL: https://github.com/apache/datafusion/issues/13898

   ### Describe the bug
   
   - part of to #13835 
   
   
   When upgrading comet to use the latest datafusion pun 
(https://github.com/andygrove/datafusion-comet/pull/1) it fails to compile with 
the following error:
   
   ```
   error[E0603]: function `swap_hash_join` is private
      --> core/src/execution/planner.rs:56:41
       |
   56  |     physical_optimizer::join_selection::swap_hash_join,
       |                                         ^^^^^^^^^^^^^^ private function
       |
   note: the function `swap_hash_join` is defined here
      --> 
/Users/andrewlamb/.cargo/git/checkouts/datafusion-c36d6291a88e48f3/e99e02b/datafusion/core/src/physical_optimizer/join_selection.rs:179:1
       |
   179 | / pub(crate) fn swap_hash_join(
   180 | |     hash_join: &HashJoinExec,
   181 | |     partition_mode: PartitionMode,
   182 | | ) -> Result<Arc<dyn ExecutionPlan>> {
       | |___________________________________^
   ```
   
   This appears to have been introduced in 
https://github.com/apache/datafusion/pull/13893 from @berkaysynnada 
   
   ### To Reproduce
   
   See https://github.com/andygrove/datafusion-comet/pull/1
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to