berkaysynnada commented on code in PR #13910:
URL: https://github.com/apache/datafusion/pull/13910#discussion_r1898451972


##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -566,8 +566,87 @@ impl HashJoinExec {
             boundedness_from_children([left, right]),
         ))
     }
+
+    /// Returns a new `ExecutionPlan` that computes the same join as this one,
+    /// with the left and right inputs swapped using the  specified
+    /// `partition_mode`.
+    ///
+    /// # Notes:
+    ///
+    /// This function is public so other downstream projects can use it to
+    /// construct `HashJoinExec` with right side as the build side.
+    pub fn swap_inputs(
+        &self,
+        partition_mode: PartitionMode,

Review Comment:
   Isn't this a parameter which is present in the HashJoinExec itself? Why are 
we separately sending it 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to