wiedld commented on code in PR #13866:
URL: https://github.com/apache/datafusion/pull/13866#discussion_r1898599827
##########
datafusion/core/src/datasource/file_format/parquet.rs:
##########
@@ -750,6 +749,26 @@ impl ParquetSink {
}
}
+ /// Create writer properties based upon configuration settings,
+ /// including partitioning and the inclusion of arrow schema metadata.
+ fn create_writer_props(&self) -> Result<WriterProperties> {
+ let props = if !self.parquet_options.global.skip_arrow_metadata {
+ let schema = if
self.parquet_options.global.allow_single_file_parallelism {
Review Comment:
This is the potential for hive-style partitioning (across multiple files)
which impacts the schema per file. I've added a code comment to explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
