alamb commented on code in PR #1624:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1624#discussion_r1898910328
##########
src/parser/mod.rs:
##########
@@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> {
}
impl Word {
+ #[deprecated(since = "0.54.0", note = "please use `into_ident` instead")]
Review Comment:
I am trying to help any downstream crates that may also use this function
with a deprecation notice rather than simply removing the function
##########
src/parser/mod.rs:
##########
@@ -13475,13 +13477,23 @@ impl<'a> Parser<'a> {
}
impl Word {
+ #[deprecated(since = "0.54.0", note = "please use `into_ident` instead")]
Review Comment:
I am trying to help any downstream crates that may also use this function
with a deprecation notice rather than simply removing the function immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
