Omega359 commented on code in PR #13936:
URL: https://github.com/apache/datafusion/pull/13936#discussion_r1899165327
##########
datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs:
##########
@@ -239,6 +239,10 @@ pub fn cell_to_string(col: &ArrayRef, row: usize) ->
Result<String> {
let key = dict.normalized_keys()[row];
Ok(cell_to_string(dict.values(), key)?)
}
+ // only added because of a bug in v 1.0.4 (is) of
lexical-write-integer
Review Comment:
Quite possible, I'll test that out. I had forgotten about that bug - the
workaround was to fix that annoyance and I moved on, forgetting even to submit
a ticket. Doh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
