alamb commented on PR #13973: URL: https://github.com/apache/datafusion/pull/13973#issuecomment-2568331788
> > We want a blocking check on the merge so on failure merge fails. Perhaps it should run on approval? > > That is a great idea I thought about this some more. I think the key property is that we don't use a version of DataFusion where hash collisions fails. If we run the new job on approval I worry we will maybe not wait for it to complete prior to merge Thus I would like to proceed with this PR - https://github.com/apache/datafusion/pull/13988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
