andygrove commented on PR #1211: URL: https://github.com/apache/datafusion-comet/pull/1211#issuecomment-2568506081
I don't think that this PR closes https://github.com/apache/datafusion-comet/issues/398 since we still fall back to Spark for SMJ with join condition unless `spark.comet.exec.sortMergeJoinWithJoinFilter.enabled=true` ? We would also need to enable the test `"SortMergeJoin with join filter"` in `CometJoinSuite`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
