jayzhan211 opened a new issue, #13998:
URL: https://github.com/apache/datafusion/issues/13998

   ### Is your feature request related to a problem or challenge?
   
   ```rust
   pub(crate) fn create_group_accumulator(
       agg_expr: &Arc<AggregateFunctionExpr>,
   ) -> Result<Box<dyn GroupsAccumulator>> {
       if agg_expr.groups_accumulator_supported() {
           agg_expr.create_groups_accumulator()
       } else {
           // Note in the log when the slow path is used
           debug!(
               "Creating GroupsAccumulatorAdapter for {}: {agg_expr:?}",
               agg_expr.name()
           );
           let agg_expr_captured = Arc::clone(agg_expr);
           let factory = move || agg_expr_captured.create_accumulator();
           Ok(Box::new(GroupsAccumulatorAdapter::new(factory)))
       }
   }
   ```
   
   If `groups_accumulator_supported` is not true, we go to the slow path.
   
   ### Describe the solution you'd like
   
   I want first/last to support goes to fast path `create_groups_accumulator`. 
It should be similar to min/max 
   
   ### Describe alternatives you've considered
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to