tobixdev commented on code in PR #14011:
URL: https://github.com/apache/datafusion/pull/14011#discussion_r1903924511
##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -333,7 +337,11 @@ impl DisplayAs for MemSink {
}
impl MemSink {
+ /// Creates a new [`MemSink`].
+ ///
+ /// The caller is responsible for ensuring that there is at least one
partition to insert into.
Review Comment:
In hindsight this would be the better API, even though its just internal.
As I don't have access to a computer for now, I'd merge it like that and if
the API ever becomes public we expose the error to the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
