djanderson commented on issue #13692:
URL: https://github.com/apache/datafusion/issues/13692#issuecomment-2576419792

   @tustvold, I gave this a thorough read today and plan to test out the 
approach soon.
   
   The only thing I'm a little flaky on is the use of the call to 
`use_current_thread()` in they rayon ThreadPoolBuilder 
[here](https://github.com/tustvold/io_stall/blob/main/src/tokio.rs#L62). The 
[docs](https://docs.rs/rayon/latest/rayon/struct.ThreadPoolBuilder.html#method.use_current_thread)
 for that method seem pretty nuanced and don't make total sense to me, so I was 
wondering if this was a small optimization (re-use the existing thread because 
why-not) or is there was something deeper there with how the task spawned on 
Rayon is allowed to interact with the tokio runtime?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to