iffyio commented on code in PR #1628:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1628#discussion_r1909593827
##########
src/ast/query.rs:
##########
@@ -2465,14 +2465,25 @@ impl fmt::Display for GroupByExpr {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
pub enum FormatClause {
- Identifier(Ident),
+ Identifier {
+ ident: Ident,
+ expr: Option<Vec<Expr>>,
+ },
Null,
}
Review Comment:
I don't think its necessary to reuse the same type given that they have
different representations - and in this case, having them share the same
representation leads to a bit of working around in the code which seems
avoidable.
Yeah it seems like it'd be InputFormatClause in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
