alamb commented on code in PR #14085:
URL: https://github.com/apache/datafusion/pull/14085#discussion_r1912430563
##########
datafusion/physical-optimizer/src/join_selection.rs:
##########
@@ -903,7 +900,7 @@ mod tests_statistical {
let original_schema = join.schema();
let optimized_join = JoinSelection::new()
- .optimize(join.clone(), &ConfigOptions::new())
+ .optimize(Arc::<HashJoinExec>::clone(&join),
&ConfigOptions::new())
Review Comment:
I think this can be simplified to the following (no need to explicitly spell
out the type):
```suggestion
.optimize(Arc::clone(&join), &ConfigOptions::new())
```
Similarly for the other changes in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
