Omega359 commented on issue #13813: URL: https://github.com/apache/datafusion/issues/13813#issuecomment-2585836320
> good find! > > > 2024 edition though... > > but maybe it's not a bad thing? https://doc.rust-lang.org/edition-guide/editions/#editions-do-not-split-the-ecosystem I tried to compile DF under nightly with 2024 edition ... there are quite a few code changes that will have to be made. #1 is rng.gen => rng.r#gen (gen is now a reserved keyword). #2 is ``` error: this pattern relies on behavior which may change in edition 2024 --> datafusion/proto-common/src/from_proto/mod.rs:443:49 | 443 | DataType::Dictionary(_, ref value_type) => { | ^^^ cannot override to bind by-reference when that is the implicit default | = note: for more information, see <https://doc.rust-lang.org/nightly/edition-guide/rust-2024/match-ergonomics.html> help: make the implied reference pattern explicit | 443 | &DataType::Dictionary(_, ref value_type) => { | + ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
