graup commented on issue #1563: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/1563#issuecomment-2587152381
Thanks for the reply @Nyrox . It seems if we just implement AttachedToken for FunctionArgumentList's parentheses, the missing spans for Value wouldn't matter much for my case, as the unioned Function span including the right parenthesis would also include anything between the function name and the right parenthesis. I looked into the code a bit and understand your struggle, somehow `FunctionArguments` needs to gain knowledge about its parentheses, kind of like `Cte` has a `closing_paren_token`, right? Turning the enum `FunctionArguments` into a struct would be a breaking change but might be the only correct way to do this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
