iffyio commented on code in PR #1645:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1645#discussion_r1913514098
##########
src/parser/mod.rs:
##########
@@ -3947,20 +3951,32 @@ impl<'a> Parser<'a> {
Ok(values)
}
+ //Parse a list of [TableWithJoins]
Review Comment:
```suggestion
/// Parse a list of [TableWithJoins]
```
##########
tests/sqlparser_snowflake.rs:
##########
@@ -2483,6 +2483,34 @@ fn test_sf_trailing_commas() {
snowflake().verified_only_select_with_canonical("SELECT 1, 2, FROM t",
"SELECT 1, 2 FROM t");
}
+#[test]
+fn test_sf_from_trailing_commas() {
Review Comment:
hmm are the tests relying on any snowflake specific feature, I imagined they
should be part of the `test_trailing_commas_in_from` in common instead?
essentially moving the tests to that file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
