comphead commented on code in PR #14086:
URL: https://github.com/apache/datafusion/pull/14086#discussion_r1913640003
##########
datafusion/macros/src/user_doc.rs:
##########
@@ -192,13 +185,13 @@ pub fn user_doc(args: TokenStream, input: TokenStream) ->
TokenStream {
let input = parse_macro_input!(input as DeriveInput);
let name = input.clone().ident;
- let doc_section_include: bool = if let Some(doc_section_include) =
doc_section_include
- {
- doc_section_include.value().parse().unwrap()
- } else {
- true
- };
-
+ let label = doc_section_lbl.as_ref().unwrap().value();
+ let doc_section_option = doc_sections_const().iter().find(|ds| ds.label ==
label);
Review Comment:
lets document this part, mentioning we trying to find a predefined const by
`label` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
