andygrove commented on code in PR #1276:
URL: https://github.com/apache/datafusion-comet/pull/1276#discussion_r1914012082
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1795,10 +1795,19 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
optExprWithInfo(optExpr, expr, child)
case InitCap(child) =>
- val castExpr = Cast(child, StringType)
- val childExpr = exprToProtoInternal(castExpr, inputs)
- val optExpr = scalarExprToProto("initcap", childExpr)
- optExprWithInfo(optExpr, expr, castExpr)
+ if (CometConf.COMET_EXEC_EXPAND_ENABLED.get()) {
Review Comment:
It looks like the wrong config is referenced here?
```suggestion
if (CometConf.COMET_EXEC_INITCAP_ENABLED.get()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
