Re: [PR] Round floats but not decimals in SqlLogicTests [datafusion]

[via GitHub]

Omega359 commented on PR #13743:
URL: https://github.com/apache/datafusion/pull/13743#issuecomment-2591129891

   > float rounding could help with some of these eg
   > <img alt="image" width="605" 
src="https://private-user-images.githubusercontent.com/144328/395788351-df0d41ff-0a70-4577-b72a-2bb8025b9f97.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY4OTAwNzIsIm5iZiI6MTczNjg4OTc3MiwicGF0aCI6Ii8xNDQzMjgvMzk1Nzg4MzUxLWRmMGQ0MWZmLTBhNzAtNDU3Ny1iNzJhLTJiYjgwMjViOWY5Ny5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDExNFQyMTIyNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05MDRlNDBhNTNhZGFjN2Y5OTFjNDY2YmY2MzA2ZWU5MTA1ZDM5MWQ4NmFjOTk2NDdlZDQ5ZDBiM2ViNWU2ODg3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.XP06kOF1SR9hyAa2IV59g_TJf7WXCeYEP_Ey4TNsNNs";>
 <img alt="image" width="463" 
src="https://private-user-images.githubusercontent.com/144328/395788376-7db70966-7c60-4785-8f14-c1b3431cc950.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.
 
eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY4OTAwNzIsIm5iZiI6MTczNjg4OTc3MiwicGF0aCI6Ii8xNDQzMjgvMzk1Nzg4Mzc2LTdkYjcwOTY2LTdjNjAtNDc4NS04ZjE0LWMxYjM0MzFjYzk1MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDExNFQyMTIyNTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hOTYxMzMwYWU5OTdmNzA0ZTM2YzNhZDA2Y2EwOGE1M2JiODJmZGRlZWU1ODVjNTFmYWQxYWFlMmQ2MzY3OTkwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.YqKUOKUI9l39Fk2tR4QjfU6O3f2ygta4t3DUe-5OIlE">
   > 
   > However, the reason why i didn't finish this PR is that even for existing 
modest number of tests this is a problem. This is because we get types 
different. For example `2.0` is apparently decimal in PostgreSQL, while it's a 
float in DF. Maybe addressing #12817 and this PR would make landing sqlite slt 
tests easier?
   
   the slt tests are in place now. We could run them with your changes and see 
what breaks and whether it's a correct breakage or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org