viirya commented on code in PR #1288: URL: https://github.com/apache/datafusion-comet/pull/1288#discussion_r1915728249
########## common/src/main/java/org/apache/comet/vector/HasRowIdMapping.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.vector; + +/** + * An interface could be implemented by vectors that have row id mapping. + * + * For example, Iceberg's DeleteFile has a row id mapping to map row id to position. + * This interface is used to set and get the row id mapping. + * The row id mapping is an array of integers, where the index is the row id and the value is the position. + * Here is an example: + * [0,1,2,3,4,5,6,7] -- Original status of the row id mapping array + * Position delete 2, 6 + * [0,1,3,4,5,7,-,-] -- After applying position deletes [Set Num records to 6] + */ +public interface HasRowIdMapping { Review Comment: Iceberg's CometVector can implement this interface to provide `rowIdMapping` to Comet. ########## common/src/main/java/org/apache/comet/vector/HasRowIdMapping.java: ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet.vector; + +/** + * An interface could be implemented by vectors that have row id mapping. + * + * For example, Iceberg's DeleteFile has a row id mapping to map row id to position. + * This interface is used to set and get the row id mapping. + * The row id mapping is an array of integers, where the index is the row id and the value is the position. + * Here is an example: + * [0,1,2,3,4,5,6,7] -- Original status of the row id mapping array + * Position delete 2, 6 + * [0,1,3,4,5,7,-,-] -- After applying position deletes [Set Num records to 6] + */ +public interface HasRowIdMapping { Review Comment: Iceberg's CometVector can implement this interface to provide `rowIdMapping` to Comet. cc @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
