alamb commented on code in PR #1655:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1655#discussion_r1918318605
##########
src/ast/mod.rs:
##########
@@ -1118,7 +1124,7 @@ impl fmt::Display for LambdaFunction {
/// `OneOrManyWithParens` implements `Deref<Target = [T]>` and `IntoIterator`,
/// so you can call slice methods on it and iterate over items
/// # Examples
-/// Acessing as a slice:
+/// Accessing as a slice:
Review Comment:
Thank you for these cleanups
##########
src/ast/value.rs:
##########
@@ -270,6 +270,27 @@ impl fmt::Display for DateTimeField {
}
}
+#[derive(Debug, Clone, PartialEq, Eq, Ord, PartialOrd, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub enum NormalizationForm {
+ NFC,
Review Comment:
Bonus points if you added some comments here (maybe referencing the postgres
docs and defining what the `NFC` and `NFD`, etc acronyms meant
I think you could copy from your very nice PR description 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
