alamb commented on code in PR #14155:
URL: https://github.com/apache/datafusion/pull/14155#discussion_r1918739595
##########
datafusion/physical-expr-common/src/sort_expr.rs:
##########
@@ -325,9 +325,13 @@ fn to_str(options: &SortOptions) -> &str {
///`LexOrdering` contains a `Vec<PhysicalSortExpr>`, which represents
/// a lexicographical ordering.
+///
+/// For example, `vec![a ASC, b DESC]` represents a lexicographical ordering
+/// that first sorts by column `a` in ascending order, then by column `b` in
+/// descending order.
#[derive(Debug, Default, Clone, PartialEq, Eq, Hash)]
pub struct LexOrdering {
- pub inner: Vec<PhysicalSortExpr>,
+ inner: Vec<PhysicalSortExpr>,
Review Comment:
this is the core change of this PR -- to make this field non pub. All the
rest of the changes follow from there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
