Omega359 commented on PR #14156: URL: https://github.com/apache/datafusion/pull/14156#issuecomment-2596973011
That's a good question @alamb. My concern with doing it in a separate PR is that other PR merges to main will fail until the tests are updated. On the flip side I'm the only one currently that can automatically regenerate the slt files so someone doesn't have to manually fix a few hundred or few thousand test cases (I have hacked up code to do it with a hacked side-branch of the sqllogictest-rs repo to do the generation). For now I think the best approach is for me to clone this branch, run the regeneration code, push a PR for the datafusion-testing repo, then once that is merged this PR be updated to include the latest hash for datafusion-testing. I'll try and do the regeneration and PR tonight but that may or may not be possible depending on how hard I race my bike tonight :) Longer term I think we'll be a bit of a better solution for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
