2010YOUY01 commented on PR #14142:
URL: https://github.com/apache/datafusion/pull/14142#issuecomment-2599597539

   Thank you for the review @alamb 
   
   > To add it to the extended suite I suggest gating the tests with a 
environment variable (so normal invocations of `cargo test ...` don't run these 
tests)
   > 
   > Perhaps like
   > 
   > ```shell
   > DATAFUSION_EXTENDED_TEST=1 cargo test --test core_integration
   > ```
   > 
   > Or something to that effect
   
   I used features instead in 
[abd5d4e](https://github.com/apache/datafusion/pull/14142/commits/abd5d4e9cdaa93374a7e0b16715f077adf006419),
 this approach seems more common


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to