logan-keede commented on issue #14184: URL: https://github.com/apache/datafusion/issues/14184#issuecomment-2601028884
I think this would require making a separate crate for `datasource` since `ProjectionPushdown` has a dependency on `datasource` in `core` unless I am missing some major and glaring fact. https://github.com/apache/datafusion/blob/3a65be0dca36c9da36d1cd9509fa89b78e49dacc/datafusion/core/src/physical_optimizer/projection_pushdown.rs#L27 If it is as I believe, I think that deserves a whole issue to itself. On a side note, would it make sense to open an issue to update imports all over the core module(don't use it if it is not necessary)? I think that should make the whole refactoring a bit less daunting. ```suggestion - use crate::error::Result; + use datafusion_common::error::Result; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
