korowa opened a new pull request, #14222:
URL: https://github.com/apache/datafusion/pull/14222
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Follow-up on #14131
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Having precalculated build-side join keys in `JoinLeftData` may be a
noticeable overhead in terms of memory (always has been, but previously it's
been recreated on each hashtable lookup), so it makes sense to add its memory
into build-side data memory reservation.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Build-side join keys memory is now accounted in memory reservation. These
keys are now collected from build-side batches iterator to increase reserved
memory size gradually (in order to reduce the risk of getting OOM killed), and
concatenated later
- Also due to arrow `concat` being non-consuming (and, thus, creating a copy
of input data), concat operations for build-side join keys and record batches
are now preceded by doubling up memory reservation for source data (trying to
predict concatenated copy size), and followed by explicit drop of source data
and resizing reservation to actual memory size of `concat` result.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing test coverage, checking that build-side join keys evaluation not
messed up.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
