alamb commented on code in PR #1669:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1669#discussion_r1923339360
##########
src/ast/spans.rs:
##########
@@ -342,6 +343,15 @@ impl Spanned for Statement {
copy_options: _,
validation_mode: _,
} => Span::empty(),
+ Statement::CopyIntoSnowflakeLocation {
Review Comment:
`CopyIntoSnowflake` shares `into`, `partition`, `file_format`,
`copy_options` fields -- did you consider keeping
`Statement::CopyIntoSnowflake` and add an enum like `target` to distinguish the
two forms?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
