iffyio commented on PR #1539: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1539#issuecomment-2606576392
@ayman-sigma `FieldAccess` being referred to was part of the 0.54 release, those changes were breaking but the syntax isn't tied to the objectName changes/this PR. I think it would be good to get this PR in since it'll be good to support the `Identifier` syntax, unfortunately that syntax isn't uncommon in Snowflake especially, and I couldn't come up with a variant that improves upon this PR in terms of being backwards compatible. I figured an alternative could be to let the parser accept the syntax but drop the `Identifier` keyword so that the actual AST isn't affected. But afaict it would only be able to support `Identifier(<string_literal> | <variable>)` variants. So I figure it would make sense with the changes as in this PR that lets us support the full syntax going forward. So my thinking was to get this PR in for the next 0.55 release, and then any further extensions to the representation can come in later releases afterwards -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org