iffyio commented on code in PR #1672:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1672#discussion_r1925519621
##########
src/tokenizer.rs:
##########
@@ -3543,4 +3546,17 @@ mod tests {
];
compare(expected, tokens);
}
+
+ #[test]
+ fn test_national_strings() {
+ let dialect = PostgreSqlDialect {};
Review Comment:
could we test the behavior both for dialects that support and don't support
backslash? (We can probably reuse the `all_dialects_where` helper function).
Also maybe the test could be called `test_national_strings_backslash_escape`
or similarly specific to the test is covering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
