iffyio commented on code in PR #1674:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1674#discussion_r1925525092
##########
src/tokenizer.rs:
##########
@@ -982,7 +982,8 @@ impl<'a> Tokenizer<'a> {
}
}
// PostgreSQL accepts "escape" string constants, which are an
extension to the SQL standard.
- x @ 'e' | x @ 'E' => {
+ x @ 'e' | x @ 'E' if dialect_of!(self is PostgreSqlDialect |
RedshiftSqlDialect | GenericDialect) =>
Review Comment:
Can we introduce a dialect method for this like `self.dialect.supports_*`?
Then in the test case we could exercise the behavior for dialects that support
vs don't support the behavior using `all_dialects_where`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
