korowa commented on code in PR #14232:
URL: https://github.com/apache/datafusion/pull/14232#discussion_r1925762754
##########
datafusion/functions-aggregate/src/first_last.rs:
##########
@@ -652,7 +652,7 @@ impl Accumulator for LastValueAccumulator {
// version in the new data:
if !self.is_set
|| self.requirement_satisfied
- || compare_rows(&self.orderings, last_ordering,
&sort_options)?.is_lt()
+ || compare_rows(&self.orderings, last_ordering,
&sort_options)?.is_le()
Review Comment:
Just a note: when the aggregation is parallelized, then "true" last value
may not be calculated anyway (if there is such a thing as a last value when
scanning multiple files).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
