alamb commented on code in PR #14190:
URL: https://github.com/apache/datafusion/pull/14190#discussion_r1926059317
##########
datafusion/physical-optimizer/Cargo.toml:
##########
@@ -41,6 +41,7 @@ datafusion-common = { workspace = true, default-features =
true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true, default-features = true }
+datafusion-functions-aggregate = { workspace = true }
Review Comment:
I would like to avoid this dependency if possible -- I will like to make a
follow on PR to remove it -- similar to how I did in
https://github.com/apache/datafusion/pull/14134
However when I just used the stub a few tests started failing on me
##########
datafusion/physical-optimizer/tests/enforce_sorting.rs:
##########
@@ -0,0 +1,861 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I like how you have split out the tests here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
