alamb commented on code in PR #14244:
URL: https://github.com/apache/datafusion/pull/14244#discussion_r1926087029
##########
datafusion/physical-optimizer/src/aggregate_statistics.rs:
##########
@@ -147,314 +147,4 @@ fn take_optimizable_value_from_statistics(
value.map(|val| (val, agg_expr.name().to_string()))
}
-#[cfg(test)]
Review Comment:
I simply moved the tests around
##########
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##########
@@ -1236,3 +1239,828 @@ async fn
test_not_replaced_with_partial_sort_for_bounded_input() -> Result<()> {
assert_optimized!(expected_input, expected_no_change, physical_plan,
false);
Ok(())
}
+
Review Comment:
I moved all the tests for the EnforceSorting pass into the same module
##########
datafusion/core/tests/physical_optimizer/aggregate_statistics.rs:
##########
@@ -0,0 +1,306 @@
+
+use datafusion_common::config::ConfigOptions;
Review Comment:
Moved into its own file for consistency. If people like this pattern I can
do it for the other tests too
##########
datafusion/physical-optimizer/tests/enforce_sorting.rs:
##########
@@ -1,861 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
This was consolidated with the exsiting `enforce_sorting.rs` tests (same for
the others below)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
