andygrove commented on code in PR #1318:
URL: https://github.com/apache/datafusion-comet/pull/1318#discussion_r1926110126
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -944,6 +974,14 @@ class CometSparkSessionExtensions
}
override def apply(plan: SparkPlan): SparkPlan = {
+
+ // Comet required off-heap memory to be enabled
+ if (!isOffHeapEnabled(conf) && !isTesting) {
+ logWarning("Comet native exec disabled because
spark.memory.offHeap.enabled=false")
+ withInfo(plan, "Comet native exec disabled because
spark.memory.offHeap.enabled=false")
+ return plan
+ }
Review Comment:
As @kazuyukitanimura noted, this change is a regression that we need to fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
