Spaarsh commented on PR #14225: URL: https://github.com/apache/datafusion/pull/14225#issuecomment-2609946746
> Thank you @Spaarsh > > I tried this out locally and found that now the conversion code was not triggered. > > I pushed a fix to your branch locally (moving where the `fi` was) as this PR has been hanging out for a while. > > ```shell > :~/Software/datafusion/benchmarks$ ./bench.sh data imdb > *************************** > DataFusion Benchmark Runner and Data Generator > COMMAND: data > BENCHMARK: imdb > DATA_DIR: /Users/andrewlamb/Software/datafusion/benchmarks/data > CARGO_COMMAND: cargo run --release > PREFER_HASH_JOIN: true > *************************** > Looking for imdb.tgz... found > Checking size... OK 1263193115 > andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion/benchmarks$ echo "foo" > data/imdb/imdb.tgz > andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion/benchmarks$ ./bench.sh data imdb > *************************** > DataFusion Benchmark Runner and Data Generator > COMMAND: data > BENCHMARK: imdb > DATA_DIR: /Users/andrewlamb/Software/datafusion/benchmarks/data > CARGO_COMMAND: cargo run --release > PREFER_HASH_JOIN: true > *************************** > Looking for imdb.tgz... found > Checking size... MISMATCH > Size less than expected: 4 found, 1263193115 required > Downloading IMDB dataset... > % Total % Received % Xferd Average Speed Time Time Time Current > Dload Upload Total Spent Left Speed > ``` Oh thanks! Sorry for the oversight. I will be more careful from now on. Thanks again! You've been extremely patient😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
