alamb commented on issue #13845: URL: https://github.com/apache/datafusion/issues/13845#issuecomment-2611139301
> I just made a PR that moves a single .slt file in `sqllogictests`. [#14254](https://github.com/apache/datafusion/pull/14254) On commit, I cant help but notice that many of them does not seem necessary. > > [@alamb](https://github.com/alamb) Perhaps we can [run github actions workflow only if the pushed files are in specific/relevant folder ](https://stackoverflow.com/questions/63822219/how-to-run-github-actions-workflow-only-if-the-pushed-files-are-in-a-specific-fo). I think this method is used in many open source projects. > > Rationale:- `why do datafusion-examples need to be tested when they have already been tested in previous merge and no changes are made to them jn this PR?` and so on.. Thanks @logan-keede -- I agree it makes sense The trick is figuring out and encoding what the dependencies are (in the sense that if a change would break a CI test, you must somehow ensure that CI test is run on the PR). I agree the current DataFusion aproach is likely an overly large hammer, but it does satisfy the requirement Examples use the DataFusion API so ensuring that any PRs that changes the API tests them I think are needed The idea of making a special case for changes only to `.slt` files is an excellent one. We do have some custom rukes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
