Omega359 commented on code in PR #14254:
URL: https://github.com/apache/datafusion/pull/14254#discussion_r1929242195
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -64,6 +66,171 @@ fn value_normalizer(s: &String) -> String {
s.trim_end().to_string()
}
+struct CustomRunner<D: AsyncDB, M: MakeConnection> {
Review Comment:
Yes. I would suggest making a PR to the sqllogictest-rs project to include
the random characters in the base runner. They've been pretty receptive to PR's
in the past, especially if you can explain the reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
