alamb commented on PR #14223: URL: https://github.com/apache/datafusion/pull/14223#issuecomment-2613928742
> Another question I would like to know is whether the u64+i64 combination is common in DataFusion? And whether we can avoid this at all. I guess u64 that is larger than i64::max is uncommon, can we aggressively use i64 even though we know it is always positive? To be clear, a `u64 + u64` in DataFusion still (even after this PR) is `u64` -- we even put a test in to verify this: https://github.com/apache/datafusion/blob/144ebf9a503d1320a9ebad8689654f38bd18c23f/datafusion/sqllogictest/test_files/operator.slt#L53 I am still not sure I fully understand in what circumstances this change might reduce performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
