logan-keede commented on code in PR #14301: URL: https://github.com/apache/datafusion/pull/14301#discussion_r1929718734
########## datafusion/sqllogictest/test_files/aggregate/string.slt: ########## Review Comment: function name is `STRING_AGG` maybe we should switch that. I think it might not be bad to have some split based on datatype like `date_time.slt` (present in this PR) even if we decide to make them redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
