iffyio commented on code in PR #1677:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1677#discussion_r1929721523
##########
tests/sqlparser_clickhouse.rs:
##########
@@ -1646,6 +1646,16 @@ fn parse_table_sample() {
clickhouse().verified_stmt("SELECT * FROM tbl SAMPLE 1 / 10 OFFSET 1 / 2");
}
+#[test]
+fn parse_numbers_with_underscore() {
+ let select = clickhouse().verified_only_select("SELECT 10_000");
Review Comment:
@graup regarding the test failure, its due to the bigdecimal representation
when the feature flag it enabled, could you try something like this for the
assertion?
```rust
let canonical = if cfg!(feature = "bigdecimal") {
"SELECT 10000"
} else {
"SELECT 10_000"
};
let select = clickhouse().one_statement_parses_to(
"SELECT 10_000",
canonical,
);
// ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
