alamb commented on code in PR #14298:
URL: https://github.com/apache/datafusion/pull/14298#discussion_r1929725541
##########
datafusion-cli/Cargo.lock:
##########
@@ -1593,7 +1593,6 @@ dependencies = [
"datafusion-execution",
"datafusion-expr",
"datafusion-expr-common",
- "datafusion-functions-aggregate",
Review Comment:
❤️
##########
datafusion/physical-optimizer/Cargo.toml:
##########
@@ -41,7 +41,6 @@ datafusion-common = { workspace = true, default-features =
true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true, default-features = true }
-datafusion-functions-aggregate = { workspace = true }
Review Comment:
🎉
##########
datafusion/core/tests/physical_optimizer/mod.rs:
##########
@@ -21,36 +21,9 @@ mod aggregate_statistics;
mod combine_partial_final_agg;
mod enforce_distribution;
mod enforce_sorting;
+mod join_selection;
+mod limit_pushdown;
mod limited_distinct_aggregation;
mod replace_with_order_preserving_variants;
mod sanity_checker;
-
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
