alamb commented on code in PR #14300:
URL: https://github.com/apache/datafusion/pull/14300#discussion_r1929726700
##########
datafusion-examples/Cargo.toml:
##########
@@ -66,6 +66,7 @@ datafusion-expr = { workspace = true }
datafusion-functions-window-common = { workspace = true }
datafusion-optimizer = { workspace = true, default-features = true }
datafusion-physical-expr = { workspace = true, default-features = true }
+datafusion-physical-optimizer = { workspace = true, default-features = true }
Review Comment:
This just follows the existing patterns so I think it is ok, but I think in
general the examples should only be using the DataFusion crate (to ensure all
relevant structures are exposed)
I will make a follow on PR
##########
datafusion/core/src/lib.rs:
##########
@@ -677,7 +677,6 @@ pub mod dataframe;
pub mod datasource;
pub mod error;
pub mod execution;
-pub mod physical_optimizer;
Review Comment:
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
