Rachelint commented on code in PR #14306: URL: https://github.com/apache/datafusion/pull/14306#discussion_r1930539706
########## datafusion/sqllogictest/test_files/aggregate/complete_aggregate.slt: ########## Review Comment: Agree with it is most improtant to keep no tests are lost and I think it ok to execute tests twice temporarily. But I think it a bit strange if we always need to execute tests in later. If we choose to keep and run all exists cases, it seems good that? - Just don't modify the old cases in `aggregate.slt`, but only rename it to `old_aggregate.slt` - And we ensure no new cases will be added into `old_aggregate.slt` anymore, and guide contributors to add cases in the new way(create a file for the function, and add cases into it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
