askalt commented on PR #14327: URL: https://github.com/apache/datafusion/pull/14327#issuecomment-2619710072
> Thank you @askalt. I'll review this in detail. > > One initial suggestion: instead of adding a unit test and introducing additional testing components, I believe the same logic can be reproduced in an .slt test. You can assert the intended plan more effectively. Thank you! I checked .slt tests, but I don't sure that for now we can assert plan properties like equivalence classes. If I overlooked it, please correct me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
