viirya commented on code in PR #1332:
URL: https://github.com/apache/datafusion-comet/pull/1332#discussion_r1932810210
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -304,11 +304,7 @@ fn scan_schema(input_batch: &InputBatch, data_types:
&[DataType]) -> SchemaRef {
.map(|(idx, c)| {
let datatype =
ScanExec::unpack_dictionary_type(c.data_type());
// We don't use the field name. Put a placeholder.
- if matches!(datatype, DataType::Dictionary(_, _)) {
- Field::new_dict(format!("col_{}", idx), datatype,
true, idx as i64, false)
Review Comment:
What you mean to re-use dictionary id across fields? Dictionary id should be
unique per field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
