jayzhan211 commented on code in PR #14268:
URL: https://github.com/apache/datafusion/pull/14268#discussion_r1933063432
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -584,23 +544,7 @@ fn get_valid_types(
match target_type_class {
TypeSignatureClass::Native(native_type) => {
let target_type = native_type.native();
- if &logical_type == target_type {
Review Comment:
@shehabgamin
I suggest with revert to the previous change and add binary->string casting
given most of the string function allow this kind of casting, but not
int->string like `ascii(2)`
For Signature::String, we can make it a convenient wrapper of
`Coercible(string, string)` or deprecate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
