alamb opened a new pull request, #14374:
URL: https://github.com/apache/datafusion/pull/14374

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion/discussions/9399
   
   
   ## Rationale for this change
   
   While writing up some notes from a conversation with @lmwnshn I got myself 
confusesed about how and if `ident_noralization` worked and couldn't find any 
tests that showed what  I wanted
   
   This is a recurring theme so I think it is worth spending time to make it 
better.
   
   See related conversation here
   - 
https://github.com/apache/datafusion/discussions/9399#discussioncomment-12007089
   
   
   
   ## What changes are included in this PR?
   1. Consolidate the tests and add some more examples showing how this setting 
works from SQL
   
   ## Are these changes tested?
   Only tests
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   Only tests.
   
   I would like to improve the documentation in this area too (specifically 
make sure the option is documented in datafusion and datafusion-python)
   
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to